Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for none config in dotfolder #1637

Merged
merged 7 commits into from
Jun 30, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
feat

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary

  • Add support for reading none config from dotfolder
  • Add relevant tests

Does this PR introduce a breaking change?
No

Other information
No

@anshumanv anshumanv requested a review from a team as a code owner June 17, 2020 04:28
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests where we have multiple configuration and load them based on mode?

@anshumanv
Copy link
Member Author

Can we add tests where we have multiple configuration and load them based on mode?

Config resolves doesn't respect mode, will add the support

@anshumanv anshumanv requested review from alexander-akait and removed request for alexander-akait June 20, 2020 08:43
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create test where we have

  • .webpack/webpack.config.developmen.js
  • webpack.config.developmen.js
  • webpack.config.js

We need test what we load the right configuration

@anshumanv
Copy link
Member Author

Yes, in near future @evilebottnawi 👍

@anshumanv
Copy link
Member Author

@evilebottnawi added 👍

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we prefer webpack.config.develoment.js over .webpack/webpack.config.development.js?

@anshumanv
Copy link
Member Author

So we prefer webpack.config.develoment.js over .webpack/webpack.config.development.js?

Yes

@alexander-akait
Copy link
Member

@webpack/cli-team we need small discussion about it, should we prefer config from .webpack directory over root configuration or not?

@rishabh3112
Copy link
Member

.webpack/* as this now what we intend to be the default directory for configurations by design.

@anshumanv
Copy link
Member Author

Seems fair

@anshumanv
Copy link
Member Author

Updated

@webpack-bot
Copy link

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

@anshumanv anshumanv merged commit 28526a6 into webpack:next Jun 30, 2020
@anshumanv anshumanv deleted the config branch June 30, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants