feat(cli-executer): validate user input #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
previously approved these changes
Jun 4, 2020
jamesgeorge007
force-pushed
the
feat/validate-input
branch
from
a72f0d9
to
19e823d
Compare
|
We already have the unit tests for |
alexander-akait
previously approved these changes
Jun 4, 2020
snitin315
previously approved these changes
Jun 4, 2020
jamesgeorge007
dismissed stale reviews from snitin315 and alexander-akait
via
29a4fc9
jamesgeorge007
force-pushed
the
feat/validate-input
branch
from
19e823d
to
29a4fc9
Compare
snitin315
approved these changes
Jun 4, 2020
rishabh3112
approved these changes
Jun 4, 2020
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
enhancement
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
Nope
Summary
An in-house warning shows up if the user doesn't supply a value for required flags as part of
cli-executer.Does this PR introduce a breaking change?
Nope
Other information
N/A