fix: prefetch flag implementation #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
commented
May 26, 2020
snitin315
force-pushed
the
fix/advanced-group
branch
from
8edc628
to
6f982d5
Compare
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
snitin315
changed the title
snitin315
force-pushed
the
fix/advanced-group
branch
from
6f982d5
to
b3f7f8c
Compare
alexander-akait
previously approved these changes
May 26, 2020
rishabh3112
approved these changes
May 27, 2020
snitin315
force-pushed
the
fix/advanced-group
branch
from
b3f7f8c
to
215e258
Compare
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
rishabh3112
approved these changes
May 27, 2020
alexander-akait
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor and tests
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
Summary
refactor AdvancedGroup, --hot and --prefetch flag implementation and corresponding tests
Does this PR introduce a breaking change?
no
Other information