Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefetch flag implementation #1583

Merged
merged 1 commit into from
May 27, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
refactor and tests

Did you add tests for your changes?
yes
If relevant, did you update the documentation?

Summary
refactor AdvancedGroup, --hot and --prefetch flag implementation and corresponding tests

Does this PR introduce a breaking change?
no

Other information

@snitin315 snitin315 requested a review from a team as a code owner May 26, 2020 04:50
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion.

packages/webpack-cli/lib/groups/AdvancedGroup.js Outdated Show resolved Hide resolved
@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

@snitin315 snitin315 changed the title refactor: improve advanced group implementation fix: prefetch flag implementation May 26, 2020
@snitin315 snitin315 closed this May 26, 2020
@snitin315 snitin315 reopened this May 26, 2020
@snitin315 snitin315 closed this May 26, 2020
@snitin315 snitin315 reopened this May 26, 2020
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more issue.

@alexander-akait alexander-akait merged commit d5d7682 into webpack:next May 27, 2020
@snitin315 snitin315 deleted the fix/advanced-group branch May 27, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants