Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages): make packages have correct main paths to index #1366

Merged
merged 3 commits into from
Mar 25, 2020

Conversation

knagaitsev
Copy link
Contributor

@knagaitsev knagaitsev commented Mar 23, 2020

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
N/A

Summary

Some of the paths to main index scripts were incorrect, causing the modules to fail

Does this PR introduce a breaking change?
No

Other information

Edit: I went through all the packages to make sure everything was correct, but certainly double-check that I didn't miss anything.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one note

yarn.lock Outdated
version "3.10.3"
resolved "https://registry.yarnpkg.com/webpack-dev-server/-/webpack-dev-server-3.10.3.tgz#f35945036813e57ef582c2420ef7b470e14d3af0"
integrity sha512-e4nWev8YzEVNdOMcNzNeCN947sWJNd43E5XvsJzbAL08kGc2frm1tQ32hTJslRS+H65LCb/AaUCYU7fjHCpDeQ==
[email protected]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here something wrong, we don't update lock file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted it back to original. It looks like the lock file was updated in a recent commit anyway, so there should be no problems either way.

@webpack-bot
Copy link

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

@alexander-akait alexander-akait merged commit 5dd7bd6 into webpack:next Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants