fix(packages): make packages have correct main paths to index #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
alexander-akait
requested changes
Mar 24, 2020
yarn.lock
Outdated
| version "3.10.3" | ||
| resolved "https://registry.yarnpkg.com/webpack-dev-server/-/webpack-dev-server-3.10.3.tgz#f35945036813e57ef582c2420ef7b470e14d3af0" | ||
| integrity sha512-e4nWev8YzEVNdOMcNzNeCN947sWJNd43E5XvsJzbAL08kGc2frm1tQ32hTJslRS+H65LCb/AaUCYU7fjHCpDeQ== | ||
| [email protected]: |
There was a problem hiding this comment.
I think here something wrong, we don't update lock file
There was a problem hiding this comment.
I reverted it back to original. It looks like the lock file was updated in a recent commit anyway, so there should be no problems either way.
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
anshumanv
approved these changes
Mar 24, 2020
jamesgeorge007
approved these changes
Mar 24, 2020
wizardofhogwarts
approved these changes
Mar 24, 2020
rishabh3112
approved these changes
Mar 25, 2020
alexander-akait
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
Some of the paths to main index scripts were incorrect, causing the modules to fail
Does this PR introduce a breaking change?
No
Other information
Edit: I went through all the packages to make sure everything was correct, but certainly double-check that I didn't miss anything.