Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 add git-cz as a dev dependency #1267

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

godcrampy
Copy link
Member

Fix errors while running $ yarn commit. reference

BREAKING CHANGE: 🧨 No

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
N/A

Summary
$ yarn commit won't work as $ npm run commit would (for npx like execution).
Instead having git-cz as a dev dependency fixes the error.

Does this PR introduce a breaking change?
Nope.

Other information

yarn commit won't work as npm commit would (for npx like execution).
Instead having git-cz as a dev dependencyprevents errors.

BREAKING CHANGE: 🧨 No
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good catch!

@ematipico ematipico merged commit b966e89 into webpack:next Feb 25, 2020
@godcrampy godcrampy deleted the bugfix/git-cz-yarn-fix branch February 25, 2020 10:49
anshumanv pushed a commit to anshumanv/webpack-cli that referenced this pull request Feb 27, 2020
yarn commit won't work as npm commit would (for npx like execution).
Instead having git-cz as a dev dependencyprevents errors.

BREAKING CHANGE: 🧨 No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants