feat: add progress bar for progress flag #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh3112
changed the title
ematipico
suggested changes
Feb 18, 2020
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
anshumanv
reviewed
Feb 18, 2020
| process.stdout.cursorTo(0); | ||
| if (percent !== undefined) { | ||
| process.stdout.write(' (') | ||
| for(let i = 0; i <= 100; i+=10) { |
There was a problem hiding this comment.
Suggested change
| for(let i = 0; i <= 100; i+=10) { | |
| for (let i = 0; i <= 100; i+=10) { |
There was a problem hiding this comment.
Is prettier not running for this file?
There was a problem hiding this comment.
Yup I think so, let me check.
There was a problem hiding this comment.
Probably you did a commit and skipped the git hooks?
There was a problem hiding this comment.
I had to run eslint with --no-ignore for it to lint.
anshumanv
approved these changes
Feb 18, 2020
ematipico
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Add a real progress bar for
--progressflag.Does this PR introduce a breaking change?
Yes
Other information