refactor!: the minimum supported webpack version is v5.0.0 #3342

snitin315 · 2022-07-19T09:05:45Z

What kind of change does this PR introduce?
Breaking change.

Did you add tests for your changes?
Already present.

If relevant, did you update the documentation?
No

Summary

The minimum supported webpack version is v5.0.0.

Does this PR introduce a breaking change?

BREAKING CHANGE:

webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0
Reset flags like --target-reset, --entry-reset flags are required to be used before using original flags like --target, --entry.

Other information
No

codecov · 2022-07-19T11:31:19Z

Codecov Report

Merging #3342 (4ee108e) into next (cae10a8) will decrease coverage by 0.13%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             next    #3342      +/-   ##
==========================================
- Coverage   93.06%   92.92%   -0.14%     
==========================================
  Files          22       22              
  Lines        1686     1669      -17     
  Branches      491      479      -12     
==========================================
- Hits         1569     1551      -18     
- Misses        117      118       +1

Impacted Files	Coverage Δ
packages/webpack-cli/src/webpack-cli.ts	`95.17% <94.44%> (-0.18%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae10a8...4ee108e. Read the comment docs.

alexander-akait

Let's separete this PR on parts to avoid regressions:

Remove old options
Remove workaround for webpack v4

Or verca vice

snitin315 · 2022-07-20T03:57:58Z

@alexander-akait I've created #3346 to remove workarounds, I'll update this PR to remove old options.

BREAKING CHANGE: webpack-cli no longer supports webpck v4, the minimum supported version is webpack v5.0.0

snitin315 · 2022-07-25T11:58:47Z

@alexander-akait Done ✅

alexander-akait · 2022-07-25T12:06:21Z

test/build/core-flags/core-flags.test.js

@@ -239,15 +239,17 @@ describe("core flags", () => {
      expect(stdout).toContain(`devtool: 'source-map'`);
    });

-    it("should allow string value devtool option using alias", async () => {
+    // TODO: Enable alias with webpack 5
+    it.skip("should allow string value devtool option using alias", async () => {


We don't have alias property coming from webpack.

https://github.com/webpack/webpack/blob/8f87b50dc7ac24eb5c91fd0d55a22e34e252863c/test/__snapshots__/Cli.basictest.js.snap#L416

We had defined alias for only few config options which we had for webpack 4 which we removed in this PR.

alexander-akait · 2022-07-25T12:07:25Z

test/help/__snapshots__/help.test.js.snap.devServer3.webpack5

  --no-target                                      Negative 'target' option.
-  -w, --watch                                      Watch for files changes.


I think keeping short -w/-d and etc make sense, they are very popular, let's keep them, what do you think?

Yes, we can add alias support for some popular flags devtool (-d), target (-t), --output-path (-o), --watch (-w)

Ideally, we should add this in the webpack schema itself.
Or we can write logic to generate an alias property for each option in webpack-cli.
Or add some workaround logic to support alias for some popular options only (coming from webpack core).

Or we can write logic to generate an alias property for each option in webpack-cli.

I think so, it was my original idea, so we will support all options using short names, we can do it separatly

Yes. Let's add them separately. In the meantime should I update the PR to keep the popular ones?

Yes, let's keep popular options here, some of them we can kept for better compatibility

@alexander-akait Added in 00fae2f

alexander-akait

Looks good

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

webpack-bot added the PR: unreviewed label Jul 19, 2022

alexander-akait reviewed Jul 19, 2022

View reviewed changes

snitin315 force-pushed the refactor/rm-webpack-4-support branch from 47f5a03 to 52f2913 Compare July 25, 2022 11:13

snitin315 force-pushed the next branch from 222c96d to cae10a8 Compare July 25, 2022 11:17

refactor!: the minimum supported webpack version is v5.0.0

e02dfea

BREAKING CHANGE: webpack-cli no longer supports webpck v4, the minimum supported version is webpack v5.0.0

snitin315 force-pushed the refactor/rm-webpack-4-support branch from 52f2913 to 63a9f59 Compare July 25, 2022 11:20

snitin315 marked this pull request as ready for review July 25, 2022 11:23

snitin315 requested a review from a team as a code owner July 25, 2022 11:23

test: update snapshots

9d1f8c1

snitin315 force-pushed the refactor/rm-webpack-4-support branch from 63a9f59 to 9d1f8c1 Compare July 25, 2022 11:31

alexander-akait reviewed Jul 25, 2022

View reviewed changes

snitin315 added 2 commits July 27, 2022 08:42

refactor: allow aliases

00fae2f

test: update snapshots

dc5dc9b

snitin315 force-pushed the refactor/rm-webpack-4-support branch from 9d2973d to dc5dc9b Compare July 27, 2022 03:25

chore: update lockfile

4ee108e

alexander-akait approved these changes Jul 27, 2022

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: unreviewed labels Jul 27, 2022

snitin315 merged commit fc293ee into next Jul 27, 2022

snitin315 deleted the refactor/rm-webpack-4-support branch July 27, 2022 09:25

snitin315 added a commit that referenced this pull request Sep 10, 2022

refactor!: the minimum supported webpack version is v5.0.0 (#3342)

e1aec5a

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

snitin315 added a commit that referenced this pull request Sep 17, 2022

refactor!: the minimum supported webpack version is v5.0.0 (#3342)

09b2c70

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

snitin315 added a commit that referenced this pull request Sep 24, 2022

refactor!: the minimum supported webpack version is v5.0.0 (#3342)

27821f5

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

snitin315 added a commit that referenced this pull request Sep 24, 2022

refactor!: the minimum supported webpack version is v5.0.0 (#3342)

60ae363

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

snitin315 added a commit that referenced this pull request Oct 8, 2022

refactor!: the minimum supported webpack version is v5.0.0 (#3342)

dbdb543

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

snitin315 added a commit that referenced this pull request Oct 22, 2022

refactor!: the minimum supported webpack version is v5.0.0 (#3342)

2a6e3b9

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

snitin315 added a commit that referenced this pull request Nov 6, 2022

refactor!: the minimum supported webpack version is v5.0.0 (#3342)

3103193

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

snitin315 added a commit that referenced this pull request Nov 8, 2022

refactor!: the minimum supported webpack version is v5.0.0 (#3342)

bdb51c0

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

alexander-akait pushed a commit that referenced this pull request Nov 15, 2022

refactor!: the minimum supported webpack version is v5.0.0 (#3342)

b1af0dc

BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!: the minimum supported webpack version is v5.0.0 #3342

refactor!: the minimum supported webpack version is v5.0.0 #3342

snitin315 commented Jul 19, 2022 •

edited

Loading

codecov bot commented Jul 19, 2022 •

edited

Loading

alexander-akait left a comment

snitin315 commented Jul 20, 2022

snitin315 commented Jul 25, 2022

alexander-akait Jul 25, 2022

snitin315 Jul 25, 2022

alexander-akait Jul 25, 2022 •

edited

Loading

snitin315 Jul 25, 2022

snitin315 Jul 25, 2022

alexander-akait Jul 25, 2022

snitin315 Jul 25, 2022

alexander-akait Jul 25, 2022

snitin315 Jul 27, 2022

alexander-akait left a comment

		--no-target Negative 'target' option.
		-w, --watch Watch for files changes.

refactor!: the minimum supported webpack version is v5.0.0 #3342

refactor!: the minimum supported webpack version is v5.0.0 #3342

Conversation

snitin315 commented Jul 19, 2022 • edited Loading

codecov bot commented Jul 19, 2022 • edited Loading

Codecov Report

alexander-akait left a comment

Choose a reason for hiding this comment

snitin315 commented Jul 20, 2022

snitin315 commented Jul 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexander-akait Jul 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexander-akait left a comment

Choose a reason for hiding this comment

snitin315 commented Jul 19, 2022 •

edited

Loading

codecov bot commented Jul 19, 2022 •

edited

Loading

alexander-akait Jul 25, 2022 •

edited

Loading