refactor: allow aliases

webpack · Jul 27, 2022 · 00fae2f · 00fae2f
1 parent 9d1f8c1
commit 00fae2f
Show file tree

Hide file tree

Showing 4 changed files with 389 additions and 386 deletions.
diff --git a/packages/webpack-cli/src/webpack-cli.ts b/packages/webpack-cli/src/webpack-cli.ts
@@ -472,6 +472,11 @@ class WebpackCLI implements IWebpackCLI {
   makeOption(command: WebpackCLICommand, option: WebpackCLIBuiltInOption) {
     let mainOption: WebpackCLIMainOption;
     let negativeOption;
+    const flagsWithAlias = ["devtool", "output-path", "target", "watch"];
+
+    if (flagsWithAlias.includes(option.name)) {
+      option.alias = option.name[0];
+    }
 
     if (option.configs) {
       let needNegativeOption = false;

diff --git a/test/build/core-flags/core-flags.test.js b/test/build/core-flags/core-flags.test.js
@@ -239,17 +239,15 @@ describe("core flags", () => {
       expect(stdout).toContain(`devtool: 'source-map'`);
     });
 
-    // TODO: Enable alias with webpack 5
-    it.skip("should allow string value devtool option using alias", async () => {
+    it("should allow string value devtool option using alias", async () => {
       const { exitCode, stderr, stdout } = await run(__dirname, ["-d", "source-map"]);
 
       expect(exitCode).toBe(0);
       expect(stderr).toBeFalsy();
       expect(stdout).toContain(`devtool: 'source-map'`);
     });
 
-    // TODO: Enable alias with webpack 5
-    it.skip("should allow string value devtool option using alias #1", async () => {
+    it("should allow string value devtool option using alias #1", async () => {
       // cSpell:ignore dsource
       const { exitCode, stderr, stdout } = await run(__dirname, ["-dsource-map"]);
 

diff --git a/test/build/target/flag-test/target-flag.test.js b/test/build/target/flag-test/target-flag.test.js
@@ -22,8 +22,7 @@ describe("--target flag", () => {
       expect(stdout).toContain(`target: [ '${val}' ]`);
     });
 
-    // TODO: Enable aliases with webpack 5
-    it.skip(`should accept ${val} with -t alias`, async () => {
+    it(`should accept ${val} with -t alias`, async () => {
       const { exitCode, stderr, stdout } = await run(__dirname, ["-t", `${val}`]);
 
       expect(exitCode).toBe(0);