fix(info): throw an error if help or version is passed as an arg (#1737)

* fix: info throws an error if help or version is passed as an arg

* tests: use --help flag as an arg to info

* refactor: use logger

* tests: fix failing test suite

packages/info/src/index.ts

@@ -1,5 +1,5 @@
-import { red } from 'colorette';
 import envinfo from 'envinfo';
+import logger from 'webpack-cli/lib/utils/logger';
 import options from './options';
 import WebpackCLI from 'webpack-cli';
 
@@ -36,10 +36,9 @@ export default async function info(...args): Promise<string[]> {
     const infoArgs = parsedArgs.opts;
     const envinfoConfig = {};
 
-    if (parsedArgs.unknownArgs.some((arg) => ['help', 'version', 'color'].includes(arg))) return;
-
     if (parsedArgs.unknownArgs.length > 0) {
-        process.stderr.write(`Unknown argument: ${red(parsedArgs.unknownArgs)}\n`);
+        logger.error(`Unknown argument: ${parsedArgs.unknownArgs}`);
+        process.exit(2);
     }
 
     if (infoArgs.output) {
@@ -53,7 +52,7 @@ export default async function info(...args): Promise<string[]> {
                 envinfoConfig['json'] = true;
                 break;
             default:
-                process.stderr.write(`${red(infoArgs.output)} is not a valid value for output\n`);
+                logger.error(`${infoArgs.output} is not a valid value for output\n`);
         }
     }
 

test/info/info-help.test.js

@@ -11,22 +11,22 @@ const descriptionText = 'Outputs information about your system and dependencies'
 
 describe('should print help for info command', () => {
     it('shows usage information on supplying help flag', () => {
-        const { stdout, stderr } = runInfo(['help'], __dirname);
+        const { stdout, stderr } = runInfo(['--help'], __dirname);
         expect(stdout).toContain(usageText);
         expect(stdout).toContain(descriptionText);
         expect(stderr).toHaveLength(0);
     });
 
     it('should respect the --no-color flag', () => {
-        const { stdout, stderr } = runInfo(['help', '--no-color'], __dirname);
+        const { stdout, stderr } = runInfo(['--help', '--no-color'], __dirname);
         options.enabled = true;
         expect(stdout).not.toContain(yellow(usageText));
         expect(stdout).toContain(descriptionText);
         expect(stderr).toHaveLength(0);
     });
 
     it('should output all cli flags', () => {
-        const { stdout, stderr } = runInfo(['help'], __dirname);
+        const { stdout, stderr } = runInfo(['--help'], __dirname);
         infoFlags.forEach((flag) => expect(stdout).toContain(`--${flag.name}`));
         expect(stderr).toHaveLength(0);
     });

test/info/info-unknown.test.js

@@ -4,6 +4,6 @@ const { runInfo } = require('../utils/test-utils');
 describe('should handle unknown args', () => {
     it('shows an appropriate warning on supplying unknown args', () => {
         const { stderr } = runInfo(['--unknown'], __dirname);
-        expect(stderr).toContain(`Unknown argument: ${red('--unknown')}`);
+        expect(stderr).toContain(`[webpack-cli] ${red('Unknown argument: --unknown')}`);
     });
 });