This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
feat: add encoding option (options.encoding)
#79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // No limits or limit more than content length | ||
| if(!limit || content.length < limit) { | ||
| if(typeof content === "string") { | ||
| content = new Buffer(content); | ||
| } | ||
|
|
||
| return "module.exports = " + JSON.stringify("data:" + (mimetype ? mimetype + ";" : "") + "base64," + content.toString("base64")); | ||
| return "module.exports = " + JSON.stringify("data:" + (mimetype ? mimetype + ";" : "") + options.encoding + "," + content.toString(options.encoding)); |
There was a problem hiding this comment.
"data:<mimetype>;<encoding>,<content...>"
return "module.exports = " + JSON.stringify("data:"
+ (mimetype ? mimetype + ";" : "")
+ (options.encoding ? options.encoding : (?*) ) + ","
+ content.toString(options.encoding ? options.encoding : (?*) ));
?* => Discuss/Triage
There was a problem hiding this comment.
return "module.exports = " + JSON.stringify("data:" + (mimetype ? mimetype + ";" : "") + encoding + "," + content.toString(encoding)
|
Reference #28 |
alexander-akait
suggested changes
Sep 13, 2017
| // No limits or limit more than content length | ||
| if(!limit || content.length < limit) { | ||
| if(typeof content === "string") { | ||
| content = new Buffer(content); | ||
| } | ||
|
|
||
| return "module.exports = " + JSON.stringify("data:" + (mimetype ? mimetype + ";" : "") + "base64," + content.toString("base64")); | ||
| return "module.exports = " + JSON.stringify("data:" + (mimetype ? mimetype + ";" : "") + options.encoding + "," + content.toString(options.encoding)); |
There was a problem hiding this comment.
return "module.exports = " + JSON.stringify("data:" + (mimetype ? mimetype + ";" : "") + encoding + "," + content.toString(encoding)
michael-ciniawsky
changed the title
options.encoding)encoding option (options.encoding)
|
@evilebottnawi 👍 But I need to revisit this first and please take a look at #28 in conjunction aswell, when time :) |
michael-ciniawsky
added
pr_action: Rework
status: Pending
and removed
pr_action: Discuss
status: Needs triage
labels
michael-ciniawsky
changed the title
encoding option (options.encoding)encoding option (options.encoding)
michael-ciniawsky
added
status: Declined
and removed
pr_action: Rework
priority: 4 (important)
status: Pending
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.