Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

feat(uglify): add missing keep_classnames, keep_fnames && safari10 options (uglifyOptions) #227

Closed
wants to merge 2 commits into from
Closed

feat(uglify): add missing keep_classnames, keep_fnames && safari10 options (uglifyOptions) #227

wants to merge 2 commits into from

Conversation

vepanimas
Copy link

@vepanimas vepanimas commented Feb 7, 2018

There are omited top-level options keep_classnames, keep_fnames and safari10 for uglify-js. I believe we should be able to use all options supported by underlying minification package.

@jsf-clabot
Copy link

jsf-clabot commented Feb 7, 2018

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title Additional uglify-js options fix: add missing keep_classnames, keep_fnames && safari10 options (uglifyOptions) Feb 8, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for each option

@alexander-akait
Copy link
Member

@vepanimas Thanks for PR. Close if favor #229

@michael-ciniawsky michael-ciniawsky removed this from the 1.2.1 milestone Feb 16, 2018
@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Feb 16, 2018

Released in v1.2.0 🎉 via #229 @vepanimas Thx for bringing this up 👍

@michael-ciniawsky michael-ciniawsky changed the title fix: add missing keep_classnames, keep_fnames && safari10 options (uglifyOptions) feat(uglify): add missing keep_classnames, keep_fnames && safari10 options (uglifyOptions) Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants