Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

TypeError: Cannot read property 'tap' of undefined (Regression in [email protected]) #241

Closed
gr2m opened this issue Feb 24, 2018 · 3 comments

Comments

@gr2m
Copy link

gr2m commented Feb 24, 2018

Hey there 👋

I see this error showing up since your last release:
https://travis-ci.org/octokit/rest.js/jobs/345401492#L3730

I wish I could help better, I'm still new to webpack and I don’t even know how uglifyjs-webpack-plugin get installed, it does not show up when I run npm ls uglifyjs-webpack-plugin.

But when I add uglifyjs-webpack-plugin as dependency and pin the version to 1.2.0, the error no longer occurs, see: https://travis-ci.org/octokit/rest.js/jobs/345502710#L3766

@michael-ciniawsky
Copy link
Member

Fix coming in a few minutes thx for the report. buildMobule... :D

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Feb 24, 2018

Released in v1.2.2 🎉

@gr2m
Copy link
Author

gr2m commented Feb 24, 2018

confirmed, thanks a ton 💐

gr2m added a commit to octokit/octokit.js that referenced this issue Feb 24, 2018
gr2m added a commit to octokit/octokit.js that referenced this issue Feb 24, 2018
@michael-ciniawsky michael-ciniawsky removed this from the 1.2.3 milestone Feb 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants