Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

feat(uglify): add missing toplevel, nameCache, keep_classnames, keep_fnames and safari10 options (uglifyOptions) #229

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

alexander-akait
Copy link
Member

Also sort options as uglify docs.

Add all options and tests. In next PR i try to implement internal cache for nameCache for increase perf 👍

@alexander-akait alexander-akait added this to the 1.2.0 milestone Feb 9, 2018
@michael-ciniawsky michael-ciniawsky changed the title feat: add missing toplevel, nameCache, keep_classnames, keep_fnames and safari10 minify options feat(minify): add missing toplevel, nameCache, keep_classnames, keep_fnames and safari10 options (uglifyOptions) Feb 15, 2018
|**`ecma`**|`{Number}`|`undefined`|Supported ECMAScript Version (`5`, `6`, `7` or `8`). Affects `parse`, `compress` && `output` options|
|**`warnings`**|`{Boolean}`|`false`|Display Warnings|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**[warnings](#warnings)**

(if there is a link, otherwise ignore)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No link

README.md Outdated
|**`nameCache`**|`{Object}`|`null`|Enable cache of mangled variable and property names across multiple invocations|
|**`ie8`**|`{Boolean}`|`false`|Enable IE8 Support|
|**`keep_classnames`**|`{Boolean}`|`undefined`|Enable prevent discarding or mangling of class names|
|**`keep_fnames`**|`{Boolean}`|`false`| Enable prevent discarding or mangling of function names. Useful for code relying on `Function.prototype.name`. If the top level minify option `keep_classnames` is `undefined` it will be overriden with the value of the top level minify option `keep_fnames`.|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ... `keep_fnames`.
+ ... `keep_fnames` 
- .

No 'final' . in Description

README.md Outdated
|**`ie8`**|`{Boolean}`|`false`|Enable IE8 Support|
|**`keep_classnames`**|`{Boolean}`|`undefined`|Enable prevent discarding or mangling of class names|
|**`keep_fnames`**|`{Boolean}`|`false`| Enable prevent discarding or mangling of function names. Useful for code relying on `Function.prototype.name`. If the top level minify option `keep_classnames` is `undefined` it will be overriden with the value of the top level minify option `keep_fnames`.|
|**`safari10`**|`{Boolean}`|`false`|Enable work around Safari 10/11 bugs in loop scoping and `await`.|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- .

@alexander-akait
Copy link
Member Author

@michael-ciniawsky done 👍

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michael-ciniawsky michael-ciniawsky merged commit 990de2a into master Feb 15, 2018
@michael-ciniawsky michael-ciniawsky deleted the feat-add-uglify-options branch February 15, 2018 18:51
@michael-ciniawsky michael-ciniawsky changed the title feat(minify): add missing toplevel, nameCache, keep_classnames, keep_fnames and safari10 options (uglifyOptions) feat(uglify): add missing toplevel, nameCache, keep_classnames, keep_fnames and safari10 options (uglifyOptions) Feb 15, 2018
@michael-ciniawsky michael-ciniawsky removed this from the 1.3.0 milestone Feb 16, 2018
@michael-ciniawsky
Copy link
Member

Released in v1.2.0 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants