Extend loader context (to support less-loader) #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The less-loader package uses the
fs
andloadModule
properties on the loader context, but those were not provided by this package. So this PR adds them in.A few notes:
fs
property is simply the imported NodeJSfs
module. So if the user has configured a different filesystem using Webpack'sinputFileSystem
option this will not be forwarded into the workers. This might cause unexpected issues, but I don't directly see a nice way around this issue.loadModule
function returns (besidessource
andsourceMap
, which are strings) themodule
, which is an instance ofNormalModule
. This class cannot be trivially serialized, so I passundefined
instead. Again, this might cause unexpected issues.Additionally, it looks like future less-loader versions will use
getResolve
instead ofresolve
just like sass-loader. So it would probably be a good idea to add support for that as well.