Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add target, minimize and resourceQuery into context #25

Merged
merged 1 commit into from
Jul 27, 2018
Merged

feat: add target, minimize and resourceQuery into context #25

merged 1 commit into from
Jul 27, 2018

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Apr 4, 2018

Resolved #24

@jsf-clabot
Copy link

jsf-clabot commented Apr 4, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 4, 2018 •
edited
Loading

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #25   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           7     7           
  Lines         372   372           
  Branches       66    66           
====================================
  Misses        325   325           
  Partials       47    47
Impacted Files Coverage Δ
src/index.js 0% <ø> (ø) ⬆️
src/worker.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ad7f2...1429de0. Read the comment docs.

@clarkdo
Copy link
Contributor Author

clarkdo commented Apr 27, 2018 •
edited
Loading

@sokra Can this be merged?

@sokra
Copy link
Member

sokra commented Jul 11, 2018

It can be merged. Cc @evilebottnawi

@clarkdo
Copy link
Contributor Author

clarkdo commented Jul 27, 2018

ping @evilebottnawi

@alexander-akait alexander-akait merged commit f3c7a2c into webpack-contrib:master Jul 27, 2018
@clarkdo
Copy link
Contributor Author

clarkdo commented Jul 27, 2018

Thanks @evilebottnawi

@alexander-akait
Copy link
Member

@clarkdo it is feature, not bugfix?

@clarkdo
Copy link
Contributor Author

clarkdo commented Jul 27, 2018

@evilebottnawi Yes, it's a new feature with some new properties.

@alexander-akait
Copy link
Member

@clarkdo published

@clarkdo clarkdo mentioned this pull request Jul 27, 2018
Merged
@clarkdo clarkdo mentioned this pull request Aug 27, 2018
Closed
@gusvargas gusvargas mentioned this pull request Nov 19, 2018
Open
@clarkdo clarkdo mentioned this pull request Feb 11, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clarkdo @jsf-clabot @sokra @alexander-akait