chore(deps): update #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@evilebottnawi unsure why the windows CI is failing. Just checked out the PR locally on my windows machine with node 10.10 and it is passing: |
|
@filipesilva yep, wip on this, I really do not like when this happens, i need to figure out why it happened |
|
For the record, also tried with the same node version as used in that Appveyor test and it also passed. Puzzling :/ |
alexander-akait
commented
Feb 4, 2019
| exports[`when applied with \`minify\` option matches snapshot for \`terser\` minifier and \`parallel\` is \`true\`: errors 1`] = ` | ||
| Array [ | ||
| "Error: main.js from Terser | ||
| SyntaxError: Unexpected string", |
There was a problem hiding this comment.
@filipesilva Problem here 😕
- No problem before
- No problem on windows
- Problem on linux
There was a problem hiding this comment.
I can't reproduce :/
Tried running it multiple times as well to see if it was a race condition or something.
If I can help let me know. Otherwise I worry that I'm just bothering you while you work.
There was a problem hiding this comment.
@filipesilva thanks for helping, do not worry, i will ping you if can't solve problem (but it is unlikely) 😄
alexander-akait
force-pushed
the
chore-deps-update
branch
from
f27e3f1 to
0d78c28
Compare
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 5 5
Lines 280 280
Branches 109 109
=======================================
Hits 276 276
Misses 4 4Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 5 5
Lines 280 280
Branches 109 109
=======================================
Hits 276 276
Misses 4 4Continue to review full report at Codecov.
|
|
@evilebottnawi a fix was merged in terser that conflics with #69. Details in terser/terser#254 (comment). Edit: tests here are still green with terser 3.16.1 so I guess my interpretation was wrong. |
alexander-akait
force-pushed
the
chore-deps-update
branch
from
0d78c28 to
01109a5
Compare
|
@filipesilva yep, problem with Input: Serilizer output: See on minify.
|
|
Rewrite test for CI, but need investigate what the hell is going on 😕 |
alexander-akait
force-pushed
the
chore-deps-update
branch
from
01109a5 to
7d07b88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Update deps
Breaking Changes
No
Additional Info
No