Add support for CSS and LESS files by default #8 #9
Conversation
|
@VovanR awesome contribution 💯 sorry for the delayed response though! Would you mind rebasing your PR? The only conflicts will be Line 65 in |
VovanR
force-pushed
the
feature/support-css
branch
from
748de0b to
498dd39
Compare
|
@JaKXz done. |
|
Now that I was going to merge, I thought this could be a breaking change for some consumers. Consumers could use specific syntax in |
|
Perhaps there should be another test that makes sure those errors aren't thrown if you have mixed style files? Though I don't think vendor libraries will actually be linted if they're |
|
If necessary, we can make this a breaking change as well, for 0.4.0 |
|
I place vendor libs to /* stylelint-disable */
@import "../bower_components/awesome-bootstrap-checkbox/awesome-bootstrap-checkbox.css";
@import "../bower_components/mdi/css/materialdesignicons.css";
@import "../bower_components/owl.carousel/dist/assets/owl.carousel.css";
@import "../bower_components/owl.carousel/dist/assets/owl.theme.default.css";
@import "../bower_components/fancybox/source/jquery.fancybox.css";
@import "../bower_components/eonasdan-bootstrap-datetimepicker/build/css/bootstrap-datetimepicker.css";
/* stylelint-enable */I do not think that this is a breaking change |
| pack(assign({}, baseConfig, config), function (err, stats) { | ||
| expect(err).to.not.exist; | ||
| expect(stats.compilation.errors.length).to.equal(4); | ||
| expect(stats.compilation.warnings.length).to.equal(0); |
There was a problem hiding this comment.
Please use the .to.have.length assertion on the errors and warnings arrays, because they provide better messages when failing.
|
@JaKXz done! |
| @@ -0,0 +1,3 @@ | |||
| body { | |||
There was a problem hiding this comment.
Could you try using sass specific syntax here?
* Update test with 'block-no-empty' rule
|
Closing in favour of #107 - thanks for your work on this. cc @barraponto |
No description provided.