Fix stylelint formatter path #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jeddy3
reviewed
Dec 18, 2016
| @@ -4,7 +4,7 @@ | |||
| var path = require('path'); | |||
| var arrify = require('arrify'); | |||
| var assign = require('object-assign'); | |||
| var formatter = require('stylelint/dist/formatters/stringFormatter').default; | |||
| var formatter = require('stylelint/lib/formatters/stringFormatter'); | |||
There was a problem hiding this comment.
I recommend you use the public API here rather than an undocumented path:
var formatter = require('stylelint').formatters.string;It'll save you from having to make changes like this in the future.
|
Can we get this published to npm soon? |
|
@agroves333 it should be in v0.4.2 (see #47). Are you not seeing it? (because I just tried it and it seems fine) |
joshwiens
pushed a commit
that referenced
this pull request
Mar 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed in stylelint/stylelint#2134