Remove duplication in updating options and binding the run function #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some jsdoc comments to the "public API"
| configFile: '.stylelintrc', | ||
| formatter: formatter, | ||
| quiet: false | ||
| }, options, { | ||
| // Default Glob is any directory level of scss and/or sass file, | ||
| // under webpack's context and specificity changed via globbing patterns | ||
| files: arrify(options.files || '**/*.s?(c|a)ss') | ||
| files: arrify(options.files || '**/*.s?(c|a)ss').map(function (file) { | ||
| // TODO: make it work with arrays |
There was a problem hiding this comment.
@vieron I'm guessing we can remove this line right?
joshwiens
pushed a commit
that referenced
this pull request
Mar 31, 2018
Add some jsdoc comments to the "public API"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was bothering me that we were calling different versions of
assignand doing it twice [my fault]. This is more consistent and less redundant [but no actual change to logic].