Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfering ownership to webpack-contrib #143

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Conversation

vieron
Copy link
Contributor

@vieron vieron commented Mar 27, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.701% when pulling 604df62 on transfer-license-ownership into 04e0f69 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 27, 2018

Coverage Status

Coverage remained the same at 98.701% when pulling 604df62 on transfer-license-ownership into 04e0f69 on master.

Copy link
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@joshwiens
Copy link
Member

joshwiens commented Mar 27, 2018

Once this merges, ping me on twitter (same name) & transfer the repository to me.

I'll transfer it into the organization, get the access setup again & get you a slack invite.

@JaKXz
Copy link
Contributor

JaKXz commented Mar 27, 2018

@d3viant0ne as long as @vieron is the commit author this is fine right? [i.e. if/when I merge I will be the committer, is that ok?]

otherwise, @vieron, if you have a moment please feel free to just merge :)

@joshwiens
Copy link
Member

Yes, the commit hash that actually modifies the license was committed by the original copyright owner. If you wanted to be super safe, use a merge commit or rebase commit to retain the hash as opposed to squash.

@JaKXz JaKXz merged commit 81a9f3b into master Mar 27, 2018
@JaKXz JaKXz deleted the transfer-license-ownership branch March 27, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants