Fix lintDirtyModulesOnly when matching path on Windows #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
JaKXz
approved these changes
Dec 22, 2017
There was a problem hiding this comment.
@MQuy thank you for your contribution! This looks like a great change. Ignore the bitHound failures, I was just trying out that service, I will remove it from the CI checks.
Unfortunately I'm not sure why node v9 is failing, I'll try to investigate.
|
@JaKXz, it is quite strange that it causes an error. The only major change is related to micromatch, but this library is used by stylelint ..., it shouldn't be a problem 🤔 |
JaKXz
changed the title
|
The issue is with I don't have the cycles atm to look into that package, but please feel free to do the deep dive :) |
|
|
joshwiens
pushed a commit
that referenced
this pull request
Mar 31, 2018
* Add micromatch * Use micromatch to check changes * Remove matchbase in micromatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run with
lintDirtyModulesOnlyoption on Window, it doesn't work due to minimatch's problem on Window. After changing minimatch into micromatch it works fine in my case, and performance is a bit better.