fix: convert back-slashes (#186)

webpack-contrib · Oct 7, 2019 · 41b0f53 · 41b0f53
1 parent 9b37d90
commit 41b0f53
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/src/LintDirtyModulesPlugin.js b/src/LintDirtyModulesPlugin.js
@@ -20,7 +20,7 @@ export default class LintDirtyModulesPlugin {
     }
 
     const dirtyOptions = { ...this.options };
-    const glob = dirtyOptions.files.join('|');
+    const glob = dirtyOptions.files.join('|').replace(/\\/g, '/');
     const changedFiles = this.getChangedFiles(compilation.fileTimestamps, glob);
 
     this.prevTimestamps = compilation.fileTimestamps;

diff --git a/test/lint-dirty-modules-only.test.js b/test/lint-dirty-modules-only.test.js
@@ -12,7 +12,7 @@ describe('lint dirty modules only', () => {
   beforeAll(() => {
     callback = jest.fn();
 
-    plugin = new LintDirtyModulesPlugin(null, { files: ['**/*.s?(c|a)ss'] });
+    plugin = new LintDirtyModulesPlugin(null, { files: ['**\\*.s?(c|a)ss'] });
     plugin.isFirstRun = false;
   });
 
@@ -32,9 +32,16 @@ describe('lint dirty modules only', () => {
   });
 
   it('linting on change file', () => {
-    const fileTimestamps = new Map([['changed.scss', 1], ['new-file.scss']]);
-
-    plugin.prevTimestamps = new Map([['changed.scss', 2]]);
+    const fileTimestamps = new Map([
+      ['foo/changed.scss', 1],
+      ['bar\\changed.scss', 1],
+      ['new-file.scss'],
+    ]);
+
+    plugin.prevTimestamps = new Map([
+      ['foo/changed.scss', 2],
+      ['bar\\changed.scss', 2],
+    ]);
     plugin.apply({ fileTimestamps }, callback);
 
     expect(linter).toBeCalledTimes(1);