Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Errors being swallowed when trying to load node-sass #576

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

jhnns
Copy link
Member

@jhnns jhnns commented Jun 1, 2018

The current try/catch is not very helpful. I think it's more helpful to just let the error bubble up.

Fixes #563
Supersedes #575

@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #576 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   97.58%   97.54%   -0.04%     
==========================================
  Files           6        6              
  Lines         124      122       -2     
==========================================
- Hits          121      119       -2     
  Misses          3        3
Impacted Files Coverage Δ
lib/loader.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437450f...8000575. Read the comment docs.

@alexander-akait alexander-akait merged commit 6dfb274 into master Jun 1, 2018
@alexander-akait alexander-akait deleted the fix/563-errors branch June 1, 2018 18:15
@jhnns
Copy link
Member Author

jhnns commented Jun 2, 2018

Shipped with 7.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants