Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: execute option #464

Merged
merged 2 commits into from
Sep 7, 2020
Merged

refactor: execute option #464

merged 2 commits into from
Sep 7, 2020

Conversation

alexander-akait
Copy link
Member

BREKING CHANGE: the exec option was renamed to the execute option

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Rename exec to execute

Breaking Changes

Yes

Additional Info

You can't rely on postcss-js name of parser, because parser can be Function and check will not work, you need to set the option to true value if you want to use postcss-js

BREKING CHANGE: the `exec` option was renamed to the `execute` option
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #464 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   97.29%   97.26%   -0.04%     
==========================================
  Files           5        5              
  Lines         222      219       -3     
  Branches       62       61       -1     
==========================================
- Hits          216      213       -3     
  Misses          6        6              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/utils.js 95.91% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ea725...e2d301f. Read the comment docs.

@alexander-akait alexander-akait merged commit 38ebe08 into master Sep 7, 2020
@alexander-akait alexander-akait deleted the refactor-execute branch September 7, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant