-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to suppress warning when used with happypack #179
Comments
@jantimon maybe we could remove whole warning? Or make it more smarter? |
Why would a loader have no access to its current compilation? What about firing the event from the compiler instead? |
@jantimon it is unavailable if you use happypack |
@ertrzyiks why? it is the general purpose intermodule communication protocol and used by many plugins.. |
@ertrzyiks Is it possible to detect Happypack usage somehow ? |
Maybe we should remove this warning? Event is very rare and I don’t think warning is very useful. |
I don't know details behind missing Having the guard condition enable people to use postcss-loader with happypack. On the other hand, the warning in the |
Done #180 |
But if @amireh could give a insight nevertheless, would be appreciated 😛 |
Released in 1.3.3 |
The reason is because In the docs for webpack 1 they dubbed it as "hacky access" to these constructs, simply because there was no better way (and I get it that the use cases are usually valid). It's just a limitation we need to live with until webpack (hopefully in v3) starts substituting their use with proper APIs. |
There is a warning, which warns happypack user about lack of support for
postcss-loader-before-processing
event to prevent potential failure with no clear reason.Once the problem is acknowledged / resolved on the user side, we may not need that warning in the build output anymore. How could we achieve that?
My ideas:
postcss-loader-before-processing
eventIf you are happy about any of those solutions or know better one, I'm willing to help to make it happen.
The text was updated successfully, but these errors were encountered: