Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs[README]: fix extract-css-chunk-plugin to mini-css-extract-plugin #696

Conversation

maddhruv
Copy link
Contributor

@maddhruv maddhruv commented Feb 6, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Was just going through the docs and found the README still saying extract-css-chunks-plugin

Breaking Changes

Additional Info

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #696 (8d3156d) into master (030c4d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files          11       11           
  Lines         696      696           
  Branches      194      194           
=======================================
  Hits          619      619           
  Misses         74       74           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030c4d3...208c360. Read the comment docs.

@maddhruv
Copy link
Contributor Author

maddhruv commented Feb 6, 2021

Well! That was quick @alexander-akait ⚡ ⚡ ⚡

@alexander-akait
Copy link
Member

Don't look at CI, WIP on tests (sometimes they are broken, but it is not you problem)

@maddhruv
Copy link
Contributor Author

maddhruv commented Feb 6, 2021

Sure!

@alexander-akait
Copy link
Member

Can you accept CLA?

@alexander-akait alexander-akait merged commit c4b375c into webpack-contrib:master Feb 8, 2021
@maddhruv maddhruv deleted the docs/rename-extract-css-plugin branch February 8, 2021 17:25
@maddhruv
Copy link
Contributor Author

maddhruv commented Feb 8, 2021

Thanks @alexander-akait for merging the PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants