-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve warning of conflict order #465
Conversation
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 88.17% 88.59% +0.42%
==========================================
Files 5 5
Lines 406 421 +15
Branches 86 90 +4
==========================================
+ Hits 358 373 +15
Misses 46 46
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please accept CLA and add test case, thanks
@evilebottnawi Hi, I have added simple unit test for it and signed CLA. Also modified the phrase a little bit. Let me know if you have any suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix test for windows
Windows test has been fixed, while lint still fails. Seems to be an issue with prettier. |
@laysent let's update lock file too (just remove old lock file and run again npm i) |
@evilebottnawi updated! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks!
This PR contains a:
Motivation / Use-Case
Many issues have been raised related to the warning of mini-css-extract-plugin regarding the conflict of order (example: #382 and #250). For me, the warning is a bit confusing as it does not provide enough details of why it goes wrong.
In this PR, I am trying to provide more info about:
In current version, running the unit test will generate the following warning:
In this PR version, running the unit test will generate the following warning:
Hopefully people seeing this warning will get an idea of checking the files in entry2, then put e2.css import later than e1.css import.
Breaking Changes
No breaking changes.
Additional Info