Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hmr support #100

Closed
wants to merge 1 commit into from
Closed

hmr support #100

wants to merge 1 commit into from

Conversation

lili21
Copy link

@lili21 lili21 commented Apr 17, 2018

fix #34

Am I doing it right?

@alexander-akait
Copy link
Member

/cc @sokra should we use style-loader for hmr or we should implement this logic inside plugin?

@nihgwu nihgwu mentioned this pull request Apr 20, 2018
Merged
lizell
lizell approved these changes Apr 27, 2018
View reviewed changes
Copy link

@lizell lizell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended

dentrado
dentrado approved these changes Apr 27, 2018
View reviewed changes
Copy link

@dentrado dentrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great together with react-universal-component!

@satazor satazor mentioned this pull request Apr 28, 2018
Merged
@miaulightouch
Copy link

I hope it would extract css in hmr mode, but it's not.

@alexander-akait
Copy link
Member

@miaulightouch yep, it is invalid solution, feel free to send new PR with feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dentrado dentrado dentrado approved these changes

@lizell lizell lizell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hot Reload plan?
5 participants
@lili21 @alexander-akait @miaulightouch @lizell @dentrado