Safe set of minification defaults

[chrisnicola]

I've reviewed a few sources and tried to put a safe set of minification defaults
that will not break common use cases such as some javascript and CSS use cases.
I've used a subset of the "safe" options from here.

Options not used are:

• Remove redundant attributes (can break styles/JS)
• Remove empty attributes (can break styles/JS)
• Remove empty elements (if the empty tag is indeed unintended it should be removed from the original)
• Minify URLs (seems like it should be at the users discretion to rewrite absolute URLs)

This addresses a number of issues: #40, #38.

[jantimon]

Any update on this?

[chrisnicola]

Ok this is getting silly, can we get some response on this? The loader needs to do the right thing by default, or people are going to consistently have problems getting started with Webpack. To make this worse since people generally only minify in production they won't even notice the problem until it reaches production. This should be being taken far more seriously than it appears to be.

[jhnns]

Thx for investing time on this 👍.

This looks good to me, I'll try to merge and publish this asap. Just waiting for write access 😁

[jhnns]

Has been published as 0.4.1 0.4.2

[mlegenhausen]

Does this solve webpack/webpack#752?

[jhnns]

Yep, I've added tests for it: 1bd81c9

[chrisnicola]

Awesome thanks @jhnns!

[kevinrenskers]

This change actually broke my layout since I depended on all whitespace being removed. Kind of strange that this pretty big change was released as a patch release.

Anyway, any way to restore the old behavior and remove conservativeCollapse?

[jhnns]

I'm sorry. You're right, this was a breaking change.

You should get back the hold behavior with this config:

{ test: /\.html$/, loader: "html?" + JSON.stringify({ minimize: true, conservativeCollapse: false }) }

[kevinrenskers]

Yep, just figured that out as well :) Thanks!

[jantimon]

cleaner: { test: /\.html$/, loader: "html", query: { minimize: true, conservativeCollapse: false } }