Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution for isuue #330 #336

Closed
wants to merge 2 commits into from

Conversation

RebelClone
Copy link

@RebelClone RebelClone commented Nov 28, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Issue #330 #330
The url of sprite svg was getting trunctared if the relative path from the sprite file left hand side was shorter comapred to right hand side

Breaking Changes

Additional Info

how to sign Contributor License Agreement (CLA)

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #336 (a95a24d) into master (348e4f5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files           7        7           
  Lines         435      435           
  Branches      111      111           
=======================================
  Hits          424      424           
  Misses         11       11           
Impacted Files Coverage Δ
src/plugins/source-plugin.js 97.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348e4f5...e74ac51. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@RebelClone
Copy link
Author

RebelClone commented Nov 28, 2020

sry but i m new to js i dont know how to add test, i wont mind if u can just change in master and not merge this

@alexander-akait
Copy link
Member

@RebelClone
Copy link
Author

is this breaking something

@cap-Bernardito cap-Bernardito mentioned this pull request Feb 6, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants