Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update jest to the latest version #193

Merged
merged 4 commits into from
Sep 18, 2022

Conversation

ersachin3112
Copy link
Contributor

@ersachin3112 ersachin3112 commented Sep 12, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

update jest to the latest version

Breaking Changes

No

Additional Info

No

@ersachin3112 ersachin3112 marked this pull request as draft September 12, 2022 09:19
@alexander-akait
Copy link
Member

Looks like we need update snapshots more

@ersachin3112 ersachin3112 marked this pull request as ready for review September 18, 2022 02:18
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Base: 95.89% // Head: 95.89% // No change to project coverage 👍

Coverage data is based on head (949561d) compared to base (b7e09f9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files           3        3           
  Lines         268      268           
  Branches      107      107           
=======================================
  Hits          257      257           
  Misses         11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -63,7 +63,7 @@
},
"dependencies": {
"cssnano": "^5.1.8",
"jest-worker": "^27.5.1",
"jest-worker": "^29.0.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is required, otherwise lint job is failing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay 👍🏻

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315 snitin315 merged commit d0a1f0f into webpack-contrib:master Sep 18, 2022
@ersachin3112 ersachin3112 deleted the update-jest branch October 2, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants