You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Could you please explain to me why the is version bumped when no changes were made to the code? This actually shows up when I have a dependency and I check for updated libraries.
Have I missed something ?
The reason will be displayed to describe this comment to others. Learn more.
It seems that all the work is done in master directly.
First, thanks for you work on the package.
If I may suggest however: create a develop branch, do pull-requests only there and merge to master only when doing a release. That way, all the changes are seen with the release's creation.
The reason will be displayed to describe this comment to others. Learn more.
@Tzaphkiel we will eventually (ideally) have css-loader maintained by more than just @sokra but our @webpack/contributor-team , you will start to see more described PR system when the code is more maintained by the team and additional contributors.
We appreciate your concern, and it appears it is for concern of the quality of the code itself.
The reason will be displayed to describe this comment to others. Learn more.
@TheLarkInn
Yes it is for QA indeed.
It is so much more comfortable to be able to rely on such concepts, there are many benefits that trickle down from it: the use of CI, the auto update to minor releases or patched one, Changelog generation, etc.
@jamiehill
Either documenting the release (Release note or Changelog) with what has changed or what is new or what has been fixed, would help the community a lot.
Don't you find it practical to look at the release note / Changelog and say: "Hum ... ah ha, so that's what's changed, yes I want that. Oh Great, this bug has been fixed, etc." ?
Having to seep through all the commits since the last commit message "release vX.y.z" is really counter productive don't you think?
278d6ccThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Could you please explain to me why the is version bumped when no changes were made to the code? This actually shows up when I have a dependency and I check for updated libraries.
Have I missed something ?
278d6ccThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that all the work is done in master directly.
First, thanks for you work on the package.
If I may suggest however: create a develop branch, do pull-requests only there and merge to master only when doing a release. That way, all the changes are seen with the release's creation.
I love it !
278d6ccThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you serious @Tzaphkiel ????
I don't think @sokra needs any help on writing an open-source library!
278d6ccThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tzaphkiel we will eventually (ideally) have
css-loadermaintained by more than just @sokra but our @webpack/contributor-team , you will start to see more described PR system when the code is more maintained by the team and additional contributors.We appreciate your concern, and it appears it is for concern of the quality of the code itself.
278d6ccThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheLarkInn
Yes it is for QA indeed.
It is so much more comfortable to be able to rely on such concepts, there are many benefits that trickle down from it: the use of CI, the auto update to minor releases or patched one, Changelog generation, etc.
@jamiehill
Either documenting the release (Release note or Changelog) with what has changed or what is new or what has been fixed, would help the community a lot.
Check projects:
https://github.com/expressjs/express/releases
https://github.com/facebook/react/releases
Don't you find it practical to look at the release note / Changelog and say: "Hum ... ah ha, so that's what's changed, yes I want that. Oh Great, this bug has been fixed, etc." ?
Having to seep through all the commits since the last commit message "release vX.y.z" is really counter productive don't you think?
You don't even have to use the tools, you can also do it with a bit more elaborate commit messages and some discipline.
e.g.: http://juristr.com/blog/2015/10/release-like-a-pro/ (cf. Issue 4: Changelog)