Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace threshold value of 10240 with 1280 #152

Closed
1 of 4 tasks
profy12 opened this issue Jan 30, 2020 · 2 comments
Closed
1 of 4 tasks

Replace threshold value of 10240 with 1280 #152

profy12 opened this issue Jan 30, 2020 · 2 comments

Comments

@profy12
Copy link

profy12 commented Jan 30, 2020 •
edited
Loading

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

In documentation like in https://github.com/webpack-contrib/compression-webpack-plugin#using-brotli you are using a threshold value of 10240 bytes, but default MTU is 1280 bytes so it should be better to use 1280. 10240 is a correct value if bit, not with bytes.

Your Proposal for Changes

Using threshold value of 1280 instead of 10240 in documentation.
@alexander-akait
Copy link
Member

Feel free to send a PR

profy12 added a commit to profy12/compression-webpack-plugin that referenced this issue Jan 30, 2020
@profy12
docs(readme): update threshold value
730e83c 
threshold value of 1280 bytes is a better value because matching the default MTU.

This close webpack-contrib#152
@profy12 profy12 mentioned this issue Jan 30, 2020
Closed
6 tasks
@alexander-akait
Copy link
Member

After reading deep about MTU, I found 1280 is not default value, it depends on other things https://en.wikipedia.org/wiki/Maximum_transmission_unit, because it is just an example I want to keep it as is, anyway thanks for the issue and the PR, sorry

@wv91364210zhuozh wv91364210zhuozh mentioned this issue Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(readme): update threshold value profy12/compression-webpack-plugin
2 participants
@profy12 @alexander-akait