This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loading-pattern
It seems like the folder structure of components have changed. When you install a component, the folder structure for each component looks something like the following:
It seems like this pattern is consistent for all of the components and there might not even be a need to read all the
component.json
files for every component and figure out version values. There might still be value for getting the name of the component, but as a quick fix, it should be ok to rely on the pattern.The other difference is the name of components in the
component.json
file. When a component is installed withcomponent install component/nameofcompoennt
the dependency fields gets updated and looks something like this:The
component/
is added which as a quick fix can be replaced with empty string when parsed.This branch hopes to address this. The fixture folder demonstrates it in action, which works in practice.