Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

Remove normalized paths from generated cache #74

Conversation

mistic
Copy link
Collaborator

@mistic mistic commented May 8, 2019

This PR removes normalized paths from the generated cache-loader caches as it would break the watch under windows due to a bug on chokidar/watchpack.

/CC @evilebottnawi

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #74 into master will decrease coverage by 0.32%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   58.13%   57.81%   -0.33%     
==========================================
  Files           2        2              
  Lines         129      128       -1     
  Branches       20       20              
==========================================
- Hits           75       74       -1     
  Misses         46       46              
  Partials        8        8
Impacted Files Coverage Δ
src/index.js 58.26% <50%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1369c05...223f61f. Read the comment docs.

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #74 into master will decrease coverage by 0.32%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   58.13%   57.81%   -0.33%     
==========================================
  Files           2        2              
  Lines         129      128       -1     
  Branches       20       20              
==========================================
- Hits           75       74       -1     
  Misses         46       46              
  Partials        8        8
Impacted Files Coverage Δ
src/index.js 58.26% <50%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1369c05...bf61ab1. Read the comment docs.

@alexander-akait alexander-akait merged commit 4bc6732 into webpack-contrib:master May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants