Fix elevation on webOS 3.x #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On webOS 3.5 (and probably 3.0), both the old and new Luna directories are used. Therefore, we have to process the new directory even if a service file is only found in the old one.
kitsuned
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On webOS 3.5 (and probably 3.0), both the old and new Luna directories are used. Therefore, we have to process the new directory even if a service file is only found in the old one.
When I added support for non-dev Luna directories, I made
elevate-serviceskip the ones without a service file to prevent creation of duplicate files. However, webOS 3.x needs API and client permission files in/var/luna-service2(-dev) even though the service files are in/var/palm/ls2(-dev). So check the legacy dirs first, and if a service file is found, don't skip the corresponding new dir.I probably didn't catch this earlier because API and client permission files aren't deleted when an app is removed, so I still had copies from a previous installation.