Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add immutable/pure support for psalm #167

Conversation

tux-rampage
Copy link

Currently assertions cannot be used in pure/immutable contexts when running psalm.
This PR aims to add @psalm-pure annotations where applicable.

@tux-rampage
Copy link
Author

Note: Build failing due to a regression in psalm (introduced in 3.8.2 - see vimeo/psalm#2649).
Fix available: #166

@tux-rampage
Copy link
Author

@BackEndTea was the rejection of this PR on purpose?

@BackEndTea
Copy link
Collaborator

It was not 😅

@BackEndTea BackEndTea reopened this Feb 14, 2020
@tux-rampage
Copy link
Author

Ok, thanks. I'll rebase this branch later.

@Ocramius
Copy link
Contributor

@tux-rampage can you give #160 (comment) a review? I'm gonna release it on a fork for now (need it on a project, not planning to publish), but I feel like we're duplicating a lot of work :S

@Ocramius
Copy link
Contributor

Tag usable @ https://github.com/Ocramius/assert-1/releases/tag/1.7.99 meanwhile

{
    "...": "...",
    "require": {
        "webmozart/assert": "^1.7.99"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/Ocramius/assert-1",
            "comment": "Temporary fork to work around the missing release of https://github.com/webmozart/assert/pull/160"
        }
    ]
}

@tux-rampage
Copy link
Author

Sure, I'll check back tomorrow.

@BackEndTea
Copy link
Collaborator

Thanks for your work @tux-rampage, but i've opted to merge #160 in favor of this PR.

@BackEndTea BackEndTea closed this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants