-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add immutable/pure support for psalm #167
Feature: Add immutable/pure support for psalm #167
Conversation
Note: Build failing due to a regression in psalm (introduced in 3.8.2 - see vimeo/psalm#2649). |
@BackEndTea was the rejection of this PR on purpose? |
It was not 😅 |
Ok, thanks. I'll rebase this branch later. |
@tux-rampage can you give #160 (comment) a review? I'm gonna release it on a fork for now (need it on a project, not planning to publish), but I feel like we're duplicating a lot of work :S |
Tag usable @ https://github.com/Ocramius/assert-1/releases/tag/1.7.99 meanwhile {
"...": "...",
"require": {
"webmozart/assert": "^1.7.99"
},
"repositories": [
{
"type": "vcs",
"url": "https://github.com/Ocramius/assert-1",
"comment": "Temporary fork to work around the missing release of https://github.com/webmozart/assert/pull/160"
}
]
} |
Sure, I'll check back tomorrow. |
Thanks for your work @tux-rampage, but i've opted to merge #160 in favor of this PR. |
Currently assertions cannot be used in pure/immutable contexts when running psalm.
This PR aims to add
@psalm-pure
annotations where applicable.