Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address caching issue where callback URLs aren't unique if the counter is ever reset #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Address caching issue where callback URLs aren't unique if the counter is ever reset #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ function jsonp(url, opts, fn){
var prefix = opts.prefix || '__jp';

// use the callback name that was passed if one was provided.
// otherwise generate a unique name by incrementing our counter.
var id = opts.name || (prefix + (count++));
// otherwise generate a unique name by using the current timestamp
var currentTime = new Date().getTime();
var id = opts.name || (prefix + currentTime);
count++;

var param = opts.param || 'callback';
var timeout = null != opts.timeout ? opts.timeout : 60000;
Expand Down