2.11.1 Carbon fails as nested module #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hopefully make Carbon work as a nested module.
decoyjoe
requested changes
Feb 28, 2022
CHANGELOG.md
Outdated
| * Fixed: Carbon fails when used as a nested module and Carbon is loaded globally or by nested in another module. | ||
|
|
||
|
|
||
| # 2.12.0 |
There was a problem hiding this comment.
Version headings are incorrect, this should be 2.11.1
There was a problem hiding this comment.
Yeah. There was some versioning confusion. 😆
Carbon/Carbon.psm1
Outdated
| @@ -94,6 +117,86 @@ $TrustedHostsPath = 'WSMan:\localhost\Client\TrustedHosts' | |||
| Write-Timing ('Adding System.DirectoryServices.AccountManagement assembly.') | |||
| Add-Type -AssemblyName 'System.DirectoryServices.AccountManagement' | |||
|
|
|||
| $MyInvocation.MyCommand.ScriptBlock.Module.OnRemove = { Write-Host 'I am being removed!' } | |||
There was a problem hiding this comment.
Did you intend to leave this here?
decoyjoe
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.