Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to resolve simple permalinks #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tjventurini
Copy link

Description

Provides logic to handle permalinks.

Checklist

  • [ ? ] All tests are passing
  • [ ? ] My code follows the code style and structure of this project

Would be awesome if you find to pull this in soon 👍

Love the package ❤️

@webmasterish
Copy link
Owner

Thank you @tjventurini for contributing and for the kind words

Your solution requires that every page needs to have a permalink property manually set in frontmatter, and that does not cover "auto" generating the URLs using the $page.path.

@tjventurini
Copy link
Author

True!

I also saw another approach where the user can overwrite the function in PLUGIN by exposing it through the plugin configuration. After I learned that I instantly regretted how I did it in this pull request - still new to vuepress and all that 😅

Maybe I'll find time to do another pull request with that approach this week, but I doubt it. It would be awesome if you could add this feature for flexibility, so everyone can overwrite the functions as he needs it 😁

@tjventurini
Copy link
Author

Another way would be to add the option of executing a closure on the image_sources~. Much like with the regular expressions that one can set up.

@webmasterish
Copy link
Owner

Same here, been too busy lately, so not sure when I can find some time to look into making PLUGIN.get_canonical_url configurable through the plugin options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants