Update module.json for v10 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not migrated to v10 as of yet and as such have not worked on making sure everything was good in the new software version. I will evaluate your changes and merge once I confirm. |
|
Everything looks fine with this. The one change that is unnecessary is the update to the download link. My main.yml file already updates that part of the json file when the release is published. However, the change won't negatively affect anything. |
webmaster94
added a commit
that referenced
this pull request
Oct 20, 2022
added contributor to the project for merge request #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module as it currently is works for v10 without issue.
This pull request resolves deprecation warnings FoundryVTT flags with this package.
Changes:
authortoauthorsentitytotypefor compendium packsrelationshipsto describePackageRelationshipsdownloadto point to v1.4 of the Waterdeep pack (though this will need to be updated after this change)