This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Support latest spec #238
Merged
Support latest spec #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Support MLOperandDataType 2. Support shape() and dataType() of MLOperand 3. Remove autoPad option of conv2d/convTranspose2d/Pool2d operations 4. Drop sync APIs 5. Drop null value of newShape for reshape 6. Drop squeeze operation 7. Drop MLBufferView Besides, updated links and corrected some outputShape of tests
huningxin
reviewed
Mar 21, 2024
|
@huningxin I've summitted new commits to address your comments. Please take another look, thanks. |
huningxin
reviewed
Mar 22, 2024
|
@huningxin Updated. Please take another review, thanks. |
|
@Honry , do you have any further comments? |
Honry
approved these changes
Mar 25, 2024
@Honry Yes, I verified update webnn-polyfill.js by locally running our WebNN Samples by Wasm and WebGL backends. Most samples can run correctly except an error "Kernel 'Complex' not registered for backend 'wasm'" happened for Noise Suppression (NSNet2) sample which is an open issue tensorflow/tfjs#5440 for tensorflow.js. |
|
@BruceDai, super cool! Thank you for your great effort! Looking forward to new release. |
|
@huningxin @Honry Thanks for reviewing. I'm going to merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me firstly apologize for this large PR. It includes below changes to align with latest WebNN API Spec.
@huningxin @Honry PTAL, thanks.