Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed computed output shape of matmul op #374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed computed output shape of matmul op #374

wants to merge 1 commit into from

Conversation

mingmingtasd
Copy link
Collaborator

@BruceDai
Copy link
Collaborator

LGTM, thanks.

@BruceDai
Copy link
Collaborator

@mingmingtasd Please also update code to compute A(1D) and B(>=2D) case, see https://github.com/webmachinelearning/webnn-polyfill/blob/a82de2fe73424ee9f7d947e443cf1ac697f88770/src/nn/ops/binary.ts#L37, thanks.

@mingmingtasd
Copy link
Collaborator Author

The CI failure hasn't been reproduced in native node testing env. There is something wrong of CI tool itsself. @BruceDai @fujunwei

@BruceDai
Copy link
Collaborator

Thanks @mingmingtasd to investigate and reproduce the failure.
For failure CI, test failed to run node tests of master branch, let's track it on #376.

@BruceDai BruceDai self-requested a review November 25, 2022 01:53
@BruceDai
Copy link
Collaborator

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceDai BruceDai Awaiting requested review from BruceDai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingmingtasd @BruceDai