Add SuperResolution example and test #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernhar
force-pushed
the
super_resolution
branch
from
a62e020 to
80aae58
Compare
|
@fujunwei PTAL! |
fujunwei
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Thanks. LGTM and left some comments.
Could you please add a ReadMe for the example like [1]?
[1] https://github.com/webmachinelearning/webnn-native/blob/main/examples/MobileNetV2/README.md
| return utils::BuildConstant(builder, data.shape, data.data<float>(), data.num_bytes()); | ||
| } | ||
|
|
||
| const wnn::Operand SuperResolution::BuildConv(const wnn::GraphBuilder& builder, |
Adds SuperResolution to WebNN!
bbernhar
force-pushed
the
super_resolution
branch
from
80aae58 to
7c4030c
Compare
|
@fujunwei I don't have the example building yet (for the README), only the test. Will come next if that's OK. |
|
make sense, merge it, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SuperResolution to WebNN!