Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DirectML version to 1.6.0 #237

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

mingmingtasd
Copy link
Collaborator

I tried to upgrade to 1.8.0 or 1.7.0, but encounter some issues: some Conv2d end2end case will get wrong result value.

[  FAILED  ] Conv2dTests.FusedDepthwiseConv2dDefault
[  FAILED  ] Conv2dTests.FusedDepthwiseConv2dNchwOhwi
[  FAILED  ] Conv2dTests.DepthwiseConv2dWithNchwOihw

So I can only upgrade to 1.6.0 (DML_FEATURE_LEVEL_4_0). I will also raise an issue to DirectML repo. @fujunwei @BruceDai

Copy link
Collaborator

@fujunwei fujunwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@huningxin
Copy link
Collaborator

Is the failure of "check memory leak for DirectML backend (windows)" bot a known issue? @BruceDai @fujunwei

@huningxin
Copy link
Collaborator

@mingmingtasd

I will also raise an issue to DirectML repo

What's the issue? Are they issues of DirectML or WebNN-native implementation? Do you have any investigations on the root cause?

I am fine to upgrade to a version with no issues, but we eventually need to support the latest DirectML release.

@mingmingtasd
Copy link
Collaborator Author

@mingmingtasd

I will also raise an issue to DirectML repo

What's the issue? Are they issues of DirectML or WebNN-native implementation? Do you have any investigations on the root cause?

I am fine to upgrade to a version with no issues, but we eventually need to support the latest DirectML release.

I am doing investigations now, will try to re-produce with the DirectML samples. I think it looks like a DirectML issue. @huningxin

@fujunwei
Copy link
Collaborator

Is the failure of "check memory leak for DirectML backend (windows)" bot a known issue? @BruceDai @fujunwei

Should we revert the CI with #236?

@mingmingtasd
Copy link
Collaborator Author

mingmingtasd commented Apr 22, 2022

I have confirmed that the conv2d issue on DirectML 1.7.0/1.80 should be their own issue. I have provided a case using their python sample to reproduce the issue and raise issue #234 to them. @fujunwei @huningxin

@fujunwei
Copy link
Collaborator

Merge it.

@fujunwei fujunwei merged commit b54c872 into webmachinelearning:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants