Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check memory leak for windows #201

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Add check memory leak for windows #201

merged 1 commit into from
Apr 19, 2022

Conversation

wangli69087
Copy link
Contributor

No description provided.

@wangli69087 wangli69087 force-pushed the memory_leak_detection branch 3 times, most recently from 3bd4cd2 to db7f43e Compare February 14, 2022 08:47
@bbernhar
Copy link
Contributor

@wangli69087 I can also add device leak checking for GPGMM-allocated DML resources if that's needed. The verifier code for GPGMM/DML tests I created is here [1], which runs against WebNN captured GPU memory traces [2]. LMK.

[1] https://github.com/intel/GPGMM/blob/c52956998962b6481d99739eaf077997ef89abe2/src/tests/D3D12Test.cpp#L32
[2] https://github.com/intel/GPGMM/blob/main/src/tests/capture_replay_tests/traces/webnn_mobilenetv2_nchw.json

@wangli69087 wangli69087 force-pushed the memory_leak_detection branch from db7f43e to 9467f45 Compare February 15, 2022 02:28
@fujunwei
Copy link
Collaborator

All jobs are green, let's merge it, thanks.

@wangli69087 wangli69087 force-pushed the memory_leak_detection branch 2 times, most recently from dda0f55 to 888a03c Compare February 15, 2022 07:22
@wangli69087 wangli69087 force-pushed the memory_leak_detection branch from 888a03c to a90024c Compare April 6, 2022 01:22
BruceDai
BruceDai reviewed Apr 12, 2022
View reviewed changes
.github/workflows/memory_leak_dml_windows.yml Outdated

job:

runs-on: windows-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangli69087 CI would fail on windows-latest (Windows Server 2022) #209, please use windows-2019 here.

BruceDai
BruceDai reviewed Apr 14, 2022
View reviewed changes
.github/workflows/build_test_dml.yml Outdated
@@ -6,7 +6,7 @@ jobs:

job:

runs-on: windows-latest
runs-on: windows-2019
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangli69087 This has already fixed in latest code, don't need to modify in your patch, please reabse your code, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue has been solved. Thanks.

@wangli69087 wangli69087 force-pushed the memory_leak_detection branch from 3e9a28f to f2123d7 Compare April 17, 2022 10:24
@wangli69087 wangli69087 force-pushed the memory_leak_detection branch from f2123d7 to 0ccf9c2 Compare April 18, 2022 13:43
@BruceDai
Copy link
Collaborator

LGTM, thanks @wangli69087
@fujunwei Please help merge this patch, thanks.

@fujunwei
Copy link
Collaborator

Merge it, thanks.

@fujunwei fujunwei merged commit 7336caf into webmachinelearning:main Apr 19, 2022
@fujunwei fujunwei mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceDai BruceDai BruceDai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangli69087 @bbernhar @fujunwei @BruceDai