Gemspec clean up #280
Gemspec clean up #280
Conversation
| @@ -1,24 +1,23 @@ | |||
| require 'rbconfig' | |||
There was a problem hiding this comment.
rbconfig doesn't appear to be used. Let's remove the require statement.
| source 'https://rubygems.org' | ||
| gemspec | ||
|
|
||
| group :development do | ||
| gem 'yard', '~> 0.9' |
There was a problem hiding this comment.
Move yard into the docs group below.
| gem 'standard', '~> 1.21' | ||
| gem 'webrick', '~> 1.7' |
There was a problem hiding this comment.
Move standard and webrick dependency declaration over from the gemspec file to be grouped here with the other development dependencies.
| gem 'rspec', '~> 3.0', '>= 3.6.0' | ||
| gem 'rspec-its', '~> 1.2' | ||
| gem 'rack', '~> 2.0' | ||
| gem 'rack-test', '~> 0.7' | ||
| gem 'rspec', '~> 3.0', '>= 3.6.0' | ||
| gem 'rspec-its', '~> 1.2' |
There was a problem hiding this comment.
Let's sort dependencies in alphabetical order.
| platform :mri_19, :mri_20 do | ||
| gem 'redcarpet', '~> 3.4' | ||
| end | ||
| gem 'redcarpet', '~> 3.4', platform: :ruby |
There was a problem hiding this comment.
Let's use the ruby platform to cover MRI version 3.x as well.
| $:.push File.expand_path('../lib', __FILE__) | ||
| require 'webmachine/version' | ||
| require_relative 'lib/webmachine/version' |
There was a problem hiding this comment.
A small simplification.
| @@ -15,6 +14,7 @@ Gem::Specification.new do |gem| | |||
| gem.email = ['[email protected]'] | |||
| gem.license = 'Apache-2.0' | |||
|
|
|||
| gem.metadata['allowed_push_host'] = 'https://rubygems.org' | |||
There was a problem hiding this comment.
Specify where the gem package should be pushed upon release.
| gem.add_runtime_dependency('i18n', ['>= 0.4.0']) | ||
| gem.add_runtime_dependency('multi_json') | ||
| gem.add_runtime_dependency('as-notifications', ['>= 1.0.2', '< 2.0']) | ||
| gem.add_runtime_dependency('base64') | ||
| gem.add_runtime_dependency('i18n', ['>= 0.4.0']) | ||
| gem.add_runtime_dependency('multi_json') |
| gem.add_development_dependency('webrick', ['~> 1.7.0']) | ||
| gem.add_development_dependency('standard', ['~> 1.21']) |
There was a problem hiding this comment.
Moved to the gemfile for consistency.
|
@seancribbs perhaps this PR has slipped through the cracks. |
|
Thank you. |
A small clean up of the gemspec and gemfile.