Add achievement overview and leaderboard #5169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jonasdeluna
force-pushed
the
feat-add-leaderboard-and-overview-achievements
branch
from
5300ead
to
6c8a446
Compare
jonasdeluna
force-pushed
the
feat-add-leaderboard-and-overview-achievements
branch
2 times, most recently
from
b12fd87
to
4dd48c6
Compare
jonasdeluna
changed the title
jonasdeluna
requested review from
eikhr and
ShaileshS1702
and removed request for
eikhr
jonasdeluna
force-pushed
the
feat-add-leaderboard-and-overview-achievements
branch
2 times, most recently
from
5174378
to
fa79b0f
Compare
jonasdeluna
force-pushed
the
feat-add-leaderboard-and-overview-achievements
branch
from
fa79b0f
to
0b4fecf
Compare
danielyanghansen
requested changes
Nov 14, 2024
| @@ -245,6 +245,7 @@ export const NotificationsFeed = { | |||
| */ | |||
| export const User = { | |||
| FETCH: generateStatuses('User.FETCH') as AAT, | |||
| FETCH_LEADERBOARD: generateStatuses('User.FETCH') as AAT, | |||
There was a problem hiding this comment.
Try to avoid using the same status for different actions
| export function fetchLeaderboardUsers() { | ||
| return callAPI<PublicUser[]>({ | ||
| types: User.FETCH_LEADERBOARD, | ||
| endpoint: `/achievements/leaderboard/`, |
There was a problem hiding this comment.
Might want to declare method as GET here
| selectUserEntities, | ||
| (userEntities) => { | ||
| return Object.values(userEntities).filter( | ||
| (user) => user.achievementScore != null, |
There was a problem hiding this comment.
might want to do
(user) => !!user.achievementScore,so that we catch undefined and 0 as well as null
| })); | ||
| const columns: ColumnProps<RankedUser>[] = [ | ||
| { | ||
| title: 'Posisjon', |
There was a problem hiding this comment.
change to "Rang" or "Rangering"?
Comment on lines
+19
to
+46
| const allTrophies = Object.entries(AchievementsInfo).flatMap( | ||
| ([key, achievements]) => | ||
| achievements.map((achievement, index) => ({ | ||
| ...achievement, | ||
| identifier: key, | ||
| level: index, | ||
| })), | ||
| ); | ||
|
|
||
| const filteredTrophies = allTrophies.filter((trophy) => { | ||
| const rarity = trophy.rarity; | ||
| const minRarity = | ||
| query.min_rarity !== 'any' ? parseInt(query.min_rarity, 10) : 0; | ||
| const maxRarity = | ||
| query.max_rarity !== 'any' ? parseInt(query.max_rarity, 10) : Infinity; | ||
| return rarity >= minRarity && rarity <= maxRarity; | ||
| }); | ||
|
|
||
| const sortedTrophies = [...filteredTrophies].sort((a, b) => { | ||
| let comparison = 0; | ||
| if (query.sort === 'rarity') comparison = a.rarity - b.rarity; | ||
| if (query.sort === 'alphabetical') | ||
| comparison = a.name.localeCompare(b.name); | ||
| if (query.sort === 'hidden') | ||
| comparison = a.hidden === b.hidden ? 0 : a.hidden ? -1 : 1; | ||
|
|
||
| return query.sort_order === 'desc' ? -comparison : comparison; | ||
| }); |
There was a problem hiding this comment.
Is there a reason we are explicitly storing each list?
I get that it's nice to divide clearly up into filtering and sorting, but it might be better to just define the filter and sorting lambda's instead and then do
const trophies =
Obejct.entries(Achievements)
.flatMap(flatMapper)
.filter(trophyFilter)
.sort(trophyComparator)where flatMapper, trophyFilter, and trophyComparator are just named lambdas:
const trophyFilter: (trophy: Trophy) => boolean = (trophy) => {
//...
} There was a problem hiding this comment.
An named lambda for the flatMapper isn't really that important though
| @@ -37,6 +38,7 @@ export const routerConfig: RouteObject[] = [ | |||
| Component: AppRoute, | |||
| children: [ | |||
| { index: true, Component: Frontpage }, | |||
| { path: 'achievements/*', children: achievementRoute }, | |||
There was a problem hiding this comment.
nit: achievementsRoute (with an s)
ch0rizo
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds achievement overview and leaderboard.
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Caution
Make sure your images do not contain any real user information.
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ... (either GitHub issue or Linear task)