Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove author field from meeting detail #5123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivarnakken
Copy link
Member

Description

I'd like to make this resemble the event details more, but I have a trouble finding an icon for both "author" and "referent", so my plan is to iterate on this by first removing the author field and get people used to that :)

The first report changelog will say it was "opprettet" so that should be sufficient

image

Testing

  • I have thoroughly tested my changes.

It is now hidden if there are any report changelogs

I'd like to make this resemble the event details more, but I have a
trouble finding an icon for both "author" and "referent", so my plan is
to iterate on this by first removing the author field and get people
used to that :)
@ivarnakken ivarnakken added review-needed Pull requests that need review small-fix Pull requests that fix something small labels Oct 30, 2024
@ivarnakken ivarnakken requested a review from a team October 30, 2024 11:21
@ivarnakken ivarnakken self-assigned this Oct 30, 2024
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 0:02am

@eikhr
Copy link
Member

eikhr commented Oct 30, 2024

I don't like this. It is a bit cumbersome to have to check the report logs to find the meeting author. For the Webkom meetings it is of course obvious who is arranging the meeting, but this isn't necessarily the case for all meetings.

@ivarnakken
Copy link
Member Author

I don't like this. It is a bit cumbersome to have to check the report logs to find the meeting author. For the Webkom meetings it is of course obvious who is arranging the meeting, but this isn't necessarily the case for all meetings.

hmm I suppose so - I'll have to think about a solution hehe

Copy link
Member

@danielyanghansen danielyanghansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but it's probably better to find a new solution (based off the reactions to Eik's response)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants