Add photo album download #2568
Add photo album download #2568
Conversation
app/actions/GalleryPictureActions.js
Outdated
| @@ -30,7 +33,7 @@ export function fetch( | |||
| }, | |||
| propagateError: true, | |||
| }) | |||
| ); | |||
| ).then(() => SelectGalleryPicturesByGalleryId(getState(), { galleryId })); | |||
There was a problem hiding this comment.
I think this should be moved into the downloadNext function inside Gallerydetail, as it is only useful for that call, and is unnecessary for the other uses of fetch.
There was a problem hiding this comment.
Good point! I was not able to move the selector to GalleryDetail, as this component does not have access to getState(). But I have now changed it to use the existing pictures prop instead, as this seems to be in sync.
In addition, I have added a gallery clear action. This is because the image URLs expire one minute after retrieval. So if the user has had the page open for longer than this, the download will fail for the already fetched images. Let me know if this is a suitable solution.
There was a problem hiding this comment.
Nice! 💯
This looks very good!
Ideally, we would do this on the server, both to offload the client, save on bandwidth to S3, and be able to cache the archive.
I think this a nice addition in any case, but IMO we should move this functionality to the backend in the future if we merge this.
Closes webkom/lego#2066
I made it possible to download an entire photo album instead of having to download each photo one by one.